jos3duardo/rinha-backend-node-2025
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor payment processors to improve concurrency and streamline payment execution

Browse Source
This commit is contained in:
Jose Eduardo 2025-08-11 23:53:12 -04:00
parent 7d5827871d
commit 2ab9284c85
3 changed files with 15 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/modules/payments/processor/payment-default.processor.ts
View File

@ -6,6 +6,7 @@ import { Repository } from 'typeorm';
import { ProcessorTypeEnum } from '../enumns/processor-type.enum'; import { ProcessorTypeEnum } from '../enumns/processor-type.enum';
import { PaymentStatusEnum } from '../enumns/payment-status.enum'; import { PaymentStatusEnum } from '../enumns/payment-status.enum';
import { MakePaymentToProcessorService } from '../services/make-payment-to-processor.service'; import { MakePaymentToProcessorService } from '../services/make-payment-to-processor.service';
import { PaymentJobData } from '../../queue/queue.service';
@Injectable() @Injectable()
export class PaymentDefaultProcessor { export class PaymentDefaultProcessor {
@ -17,7 +18,7 @@ export class PaymentDefaultProcessor {
private makePaymentToProcessorService: MakePaymentToProcessorService, private makePaymentToProcessorService: MakePaymentToProcessorService,
) {} ) {}
async execute(payment: Payment): Promise<boolean> { async execute(payment: PaymentJobData): Promise<boolean> {
const url = this.configService.get('paymentProcessors.defaultUrl'); const url = this.configService.get('paymentProcessors.defaultUrl');
const responseExists = await this.makePaymentToProcessorService.execute( const responseExists = await this.makePaymentToProcessorService.execute(
@ -26,8 +27,10 @@ export class PaymentDefaultProcessor {
); );
if (responseExists) { if (responseExists) {
await this.repository.update(payment.id, { await this.repository.save({
...payment, amount: payment.paymentData.amount,
correlationId: payment.paymentData.correlationId,
createdAt: payment.createdAt,
paymentProcessor: ProcessorTypeEnum.DEFAULT, paymentProcessor: ProcessorTypeEnum.DEFAULT,
status: PaymentStatusEnum.SUCCESS, status: PaymentStatusEnum.SUCCESS,
}); });

9
src/modules/payments/processor/payment-fallback.processor.ts
View File

@ -6,6 +6,7 @@ import { Repository } from 'typeorm';
import { ProcessorTypeEnum } from '../enumns/processor-type.enum'; import { ProcessorTypeEnum } from '../enumns/processor-type.enum';
import { PaymentStatusEnum } from '../enumns/payment-status.enum'; import { PaymentStatusEnum } from '../enumns/payment-status.enum';
import { MakePaymentToProcessorService } from '../services/make-payment-to-processor.service'; import { MakePaymentToProcessorService } from '../services/make-payment-to-processor.service';
import { PaymentJobData } from '../../queue/queue.service';
@Injectable() @Injectable()
export class PaymentFallbackProcessor { export class PaymentFallbackProcessor {
@ -17,7 +18,7 @@ export class PaymentFallbackProcessor {
private makePaymentToProcessorService: MakePaymentToProcessorService, private makePaymentToProcessorService: MakePaymentToProcessorService,
) {} ) {}
async execute(payment: Payment): Promise<boolean> { async execute(payment: PaymentJobData): Promise<boolean> {
const url = this.configService.get('paymentProcessors.fallbackUrl'); const url = this.configService.get('paymentProcessors.fallbackUrl');
const responseExists = await this.makePaymentToProcessorService.execute( const responseExists = await this.makePaymentToProcessorService.execute(
@ -26,8 +27,10 @@ export class PaymentFallbackProcessor {
); );
if (responseExists) { if (responseExists) {
await this.repository.update(payment.id, { await this.repository.save({
...payment, amount: payment.paymentData.amount,
correlationId: payment.paymentData.correlationId,
createdAt: payment.createdAt,
paymentProcessor: ProcessorTypeEnum.FALLBACK, paymentProcessor: ProcessorTypeEnum.FALLBACK,
status: PaymentStatusEnum.SUCCESS, status: PaymentStatusEnum.SUCCESS,
}); });

17
src/modules/payments/processor/payment.processor.ts
View File

@ -5,7 +5,7 @@ import { Injectable, Logger } from '@nestjs/common';
import { ProcessPaymentService } from '../services/process-payment.service'; import { ProcessPaymentService } from '../services/process-payment.service';
import { PAYMENT_QUEUE } from '../../queue/constants/queue.constants'; import { PAYMENT_QUEUE } from '../../queue/constants/queue.constants';
@Processor(PAYMENT_QUEUE) @Processor(PAYMENT_QUEUE, { concurrency: 2 })
@Injectable() @Injectable()
export class PaymentProcessor extends WorkerHost { export class PaymentProcessor extends WorkerHost {
private readonly logger = new Logger(PaymentProcessor.name); private readonly logger = new Logger(PaymentProcessor.name);
@ -15,18 +15,7 @@ export class PaymentProcessor extends WorkerHost {
} }
async process(job: Job<PaymentJobData>) { async process(job: Job<PaymentJobData>) {
const { paymentId, retryCount = 0 } = job.data; const payment = job.data;
await this.processPaymentService.execute(payment);
try {
await this.processPaymentService.execute(paymentId);
return { success: true, paymentId };
} catch (error) {
this.logger.error(
`Failed to process payment ${paymentId}:`,
error.message,
);
throw error;
}
} }
} }