jos3duardo/rinha-backend-node-2025
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor payment processor type checks to use enum values

Browse Source
This commit is contained in:
Jose Eduardo 2025-08-10 21:06:11 -04:00
parent 474dc1af56
commit 397fc866ec
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/modules/payments/services/payments-summary.service.ts
View File

@ -4,6 +4,7 @@ import { Payment } from '../entities/payment.entity';
import { Repository } from 'typeorm'; import { Repository } from 'typeorm';
import { QueueService } from '../../queue/queue.service'; import { QueueService } from '../../queue/queue.service';
import { PaymentStatusEnum } from '../enumns/payment-status.enum'; import { PaymentStatusEnum } from '../enumns/payment-status.enum';
import { ProcessorTypeEnum } from '../enumns/processor-type.enum';
@Injectable() @Injectable()
export class PaymentsSummaryService { export class PaymentsSummaryService {
@ -21,7 +22,9 @@ export class PaymentsSummaryService {
.addSelect('COUNT(*)', 'totalRequests') .addSelect('COUNT(*)', 'totalRequests')
.addSelect('SUM(payment.amount)', 'totalAmount') .addSelect('SUM(payment.amount)', 'totalAmount')
.where('payment.createdAt BETWEEN :from AND :to', { from, to }) .where('payment.createdAt BETWEEN :from AND :to', { from, to })
.where('payment.status = :status', { status: PaymentStatusEnum.SUCCESS }) .andWhere('payment.status = :status', {
status: PaymentStatusEnum.SUCCESS,
})
.groupBy('payment.paymentProcessor'); .groupBy('payment.paymentProcessor');
const results = await qb.getRawMany(); const results = await qb.getRawMany();
@ -32,10 +35,10 @@ export class PaymentsSummaryService {
}; };
for (const row of results) { for (const row of results) {
if (row.processorType === 'default') { if (row.processorType === ProcessorTypeEnum.DEFAULT) {
summary.default.totalRequests = Number(row.totalRequests); summary.default.totalRequests = Number(row.totalRequests);
summary.default.totalAmount = Number(row.totalAmount); summary.default.totalAmount = Number(row.totalAmount);
} else if (row.processorType === 'fallback') { } else if (row.processorType === ProcessorTypeEnum.FALLBACK) {
summary.fallback.totalRequests = Number(row.totalRequests); summary.fallback.totalRequests = Number(row.totalRequests);
summary.fallback.totalAmount = Number(row.totalAmount); summary.fallback.totalAmount = Number(row.totalAmount);
} }