jos3duardo/rinha-backend-node-2025
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor payment processing to utilize PaymentJobData and streamline execution logic

Browse Source
This commit is contained in:
Jose Eduardo 2025-08-11 23:53:58 -04:00
parent d28c9897da
commit 7773a4f45e
1 changed files with 4 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
src/modules/payments/services/process-payment.service.ts
View File

@ -1,64 +1,19 @@
import { Injectable, Logger } from '@nestjs/common'; import { Injectable, Logger } from '@nestjs/common';
import { InjectRepository } from '@nestjs/typeorm';
import { Payment } from '../entities/payment.entity';
import { Repository } from 'typeorm';
import { HealthService } from '../../health/services/health.service';
import { ProcessorTypeEnum } from '../enumns/processor-type.enum';
import { PaymentStatusEnum } from '../enumns/payment-status.enum';
import { PaymentDefaultProcessor } from '../processor/payment-default.processor'; import { PaymentDefaultProcessor } from '../processor/payment-default.processor';
import { PaymentFallbackProcessor } from '../processor/payment-fallback.processor'; import { PaymentFallbackProcessor } from '../processor/payment-fallback.processor';
import { PaymentJobData } from '../../queue/queue.service';
@Injectable() @Injectable()
export class ProcessPaymentService { export class ProcessPaymentService {
private readonly logger = new Logger(ProcessPaymentService.name); private readonly logger = new Logger(ProcessPaymentService.name);
constructor( constructor(
@InjectRepository(Payment) private readonly repository: Repository<Payment>,
private healthService: HealthService,
private paymentDefaultProcessor: PaymentDefaultProcessor, private paymentDefaultProcessor: PaymentDefaultProcessor,
private paymentFallbackProcessor: PaymentFallbackProcessor, private paymentFallbackProcessor: PaymentFallbackProcessor,
) {} ) {}
async execute(paymentId: string): Promise<void> { async execute(job: PaymentJobData): Promise<void> {
const payment = await this.repository.findOne({ const result = await this.paymentDefaultProcessor.execute(job);
where: { id: paymentId }, if (!result) await this.paymentFallbackProcessor.execute(job);
});
if (!payment) {
throw new Error(`Payment ${paymentId} not found`);
}
await this.repository.update(paymentId, {
status: PaymentStatusEnum.PROCESSING,
});
const preferredProcessor = this.healthService.getPreferredProcessor();
if (!preferredProcessor) {
throw new Error('No payment processor available');
}
try {
if (preferredProcessor === ProcessorTypeEnum.DEFAULT) {
await this.paymentDefaultProcessor.execute(payment);
} else {
await this.paymentFallbackProcessor.execute(payment);
}
} catch (error) {
this.logger.error(
`Error processing payment ${paymentId}:`,
error.message,
);
const status =
payment.attempts >= 2
? PaymentStatusEnum.FAILED
: PaymentStatusEnum.RETRY;
await this.repository.update(payment.id, {
status,
attempts: +payment.attempts + 1,
});
}
} }
} }