From ddba8be6a4452da0dd6f56bb14e6c28adadac180 Mon Sep 17 00:00:00 2001 From: Jayden Seric Date: Wed, 10 Feb 2021 00:30:41 +1100 Subject: [PATCH] Use prop-types, update ESLint config. --- app/.eslintrc.json | 11 ++++++++--- app/components/Page.js | 6 ++++++ app/package-lock.json | 1 + app/package.json | 1 + 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/app/.eslintrc.json b/app/.eslintrc.json index 216de14..1d3c203 100644 --- a/app/.eslintrc.json +++ b/app/.eslintrc.json @@ -1,6 +1,11 @@ { "extends": ["env"], - "rules": { - "react/prop-types": "off" - } + "overrides": [ + { + "files": ["components/**/*.js", "pages/**/*.js"], + "rules": { + "jsdoc/require-jsdoc": "off" + } + } + ] } diff --git a/app/components/Page.js b/app/components/Page.js index 58ed106..2f3834e 100644 --- a/app/components/Page.js +++ b/app/components/Page.js @@ -1,4 +1,5 @@ import Head from 'next/head'; +import PropTypes from 'prop-types'; export const Page = ({ title, children }) => ( <> @@ -8,3 +9,8 @@ export const Page = ({ title, children }) => ( {children} ); + +Page.propTypes = { + title: PropTypes.string.isRequired, + children: PropTypes.node.isRequired +} diff --git a/app/package-lock.json b/app/package-lock.json index 5496cb0..27084a9 100644 --- a/app/package-lock.json +++ b/app/package-lock.json @@ -12,6 +12,7 @@ "device-agnostic-ui": "^7.0.1", "graphql": "^15.5.0", "next": "^10.0.6", + "prop-types": "^15.7.2", "react": "^17.0.1", "react-dom": "^17.0.1" }, diff --git a/app/package.json b/app/package.json index 4c73301..fcaaba5 100644 --- a/app/package.json +++ b/app/package.json @@ -26,6 +26,7 @@ "device-agnostic-ui": "^7.0.1", "graphql": "^15.5.0", "next": "^10.0.6", + "prop-types": "^15.7.2", "react": "^17.0.1", "react-dom": "^17.0.1" },